react-component / input-number

React Input Number

Home Page:https://input-number.vercel.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Regression with v7: precision and formatter collide

Mathieuu opened this issue · comments

Since v7, the precision is skipped if a formatter is passed.

Here's an example with precision 2 and a formatter adding columns for every thousand: 100,000.00

With v6.1.2:
https://codesandbox.io/s/spring-sunset-dwr0o?file=/src/App.js

With v7
https://codesandbox.io/s/trusting-dan-vmhmc?file=/src/App.js

Here's the fault line: https://github.com/react-component/input-number/blob/master/src/InputNumber.tsx#L175

I am not sure what the right fix would be though.

Here to comment on the same, seems like this is not a priority but its a big development pain