Hijackable Logger
crazytyper opened this issue · comments
Georg Schreiber commented
Given a tigertonic based server that serves both REST and web socket endpoints.
And the server uses a logged HTTP handler (e.g. tigertonic.ApacheLogged()
).
When accessing a web socket API the request will fail complaining that apacheLoggerResponseWriter
is not hijack-able (i.e. does not implement http.Hijacker
).
The logged HTTP handlers should use response writers that are fully transparent. The logged response writer should support hijacking if the underlying response writer does.
A simple fix would be to add method Hijack
to the logged response writers. However, this does not feel 100% right.