Does not allow passing arguments
kantord opened this issue · comments
Describe the bug
If I run
TestNearest -u
then vim-test will update my jest snapshots (-u updates snapshot tests)
however if I run
UltestNearest -u
then it does not update the tests
To Reproduce
- open any project with jest snapshot testing. Find examples on GitHub
- run the commands as described above
Expected behavior
Ultest should pass all the arguments to vim-test so that it works the same way
Ultest does not support setting arguments using the commands like vim-test does. You have to set the variable to configure your runner arguments beforehand.
It would be nice if it was supported. Are you against this feature in general?
You have to set the variable to configure your runner arguments beforehand.
This only works for the use case when you pass arguments for the purposes of configuration. -u actually sends an instruction to jest to update snapshots. Putting that in the runner configuration would be an invalid usage of jest
Or is there an alternative way to support jest snapshot testing? I could not find any other issues or any documentation regarding this: https://github.com/rcarriga/vim-ultest/search?q=snapshot&type=issues
I'm not opposed to having command line parsing, I just have no use of it myself and have never done it in vimscript before so haven't gotten around to it. Totally open to PRs though!
Alternatively you could script it to have another command to alter the config var to add -u for the one usage and then remove it. There is also g:ultest_pre_run which might also be useful but might not if you only want to set it manually