Wrong trick winner after taking back last play
czhang23 opened this issue · comments
First, thank you for making this. We found this is very enjoyable!
Below is the log.
In last play, Yang should have won the trick after the new play. But S won the play. In the attached image, even the log says S won the play, the score won by S&Hook is only 75. But, in Yang's hand, NJ is not there any more.
BTW, Lin clicked the Finish Trick.
GAME: Lin started the game
GAME: S bid 6♦
GAME: Yang played J♣J♣
GAME: Hook played A♣A♣
GAME: Lin played 4♣4♣
GAME: S played 5♣9♣
GAME: Hook wins the trick and gets 5 points
GAME: Hook played A♠
GAME: Lin played 2♠
GAME: S played K♠
GAME: Yang played 2♠
GAME: Hook wins the trick and gets 10 points
GAME: S is being shadowed
GAME: Hook played Q♣Q♣
GAME: Lin played K♣K♣
GAME: S played 7♦7♦
GAME: Yang played 2♣2♣
GAME: S wins the trick and gets 20 points
GAME: S played 2♥2♥3♥3♥
GAME: Yang played 3♠9♠7♥7♥
GAME: Hook played J♥J♥A♥A♥
GAME: Lin played 5♥9♥10♥K♥
GAME: S wins the trick and gets 25 points
GAME: S played 2♦
GAME: Yang played 6♠
GAME: Hook played HJ
GAME: Lin played 3♦
GAME: Hook wins the trick, but gets no points :(
GAME: Hook played 7♣7♣
GAME: Lin played 3♣8♣
GAME: S played 3♠5♠
GAME: Yang played J♠Q♠
GAME: Hook wins the trick and gets 5 points
GAME: Hook played 8♣10♣
GAME: Lin played 4♠7♠
GAME: S played 8♦6♦
GAME: Yang played 2♦10♦
GAME: Yang took back their last play
GAME: Yang played 2♦HJ
GAME: S wins the trick and gets 10 points
Thanks for filing this bug report! It looks like you may have been playing the game using the "throw must beat all parts" setting. So, because S played 8d6d, and Yang played 2dHJ, the 2d was smaller than 8d and smaller than 6d, so S would win the trick. If Yang had played 7d9d or higher (so that there was a card higher than each card), then Yang would have won.
Please let me know if that's not the setting you were playing with. That is the default. It can be changed to beating the highest card, or beating the biggest part.
Indeed. We overlooked the settings when we check it. It is really complicated when we realized that there are so many varieties. It is amazing this project can handle most of them. Thanks for your reply!
If we choose "beat the largest component", is component defined by the original multi-throw?
AKQ, kill 44J, kill A5K, can A5K beat 44J?
Good question. The largest component is defined by the original multithrow. So, in your example, A-K-Q is 3 1-tuples. So A-5-K > 4-4-J. Alternatively, if the original format is AA-K, 55-J beats 44-A