rbtcollins / fs_at

Filesystem 'at' implementations for Unix and Windows

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Trying to build for target_os="ios" fails

travis79 opened this issue · comments

use libc::openat64;

When using this crate on a project built for target_os="ios" the above line is causing a build failure.

error[E0432]: unresolved import `libc::openat64`
  -->~/.cargo/registry/src/github.com-1ecc6299db9ec823/fs_at-0.1.1/src/unix.rs:17:13
   |
17 |         use libc::openat64;
   |             ^^^^^^--------
   |             |     |
   |             |     help: a similar name exists in the module: `openat`
   |             no `openat64` in the root

Could you test if adding to the list of oses on this branch :

 if #[cfg(any(target_os="macos", target_os="freebsd"))] {

fixes it and passes tests?

Sure, let's try....

Tests pass after adding target_os="ios":

running 10 tests
test tests::readdir_sync_send ... ok
test tests::check_eloop_raw_os_value ... ok
test tests::symlink_at ... ok
test unix::tests::mkdirat_mode ... ok
test tests::open_dir_at ... ok
test tests::readdir ... ok
test tests::all_unlink ... ok
test tests::all_rmdir ... ok
test tests::all_mkdir ... ok
test tests::all_open_file ... ok

test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.45s

   Doc-tests fs_at

running 1 test
test src/unix.rs - unix::OpenOptionsExt (line 219) - compile ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

And it also does fix my local build

Thank you, release has gone through, should be cargo installable now.

Indeed, I can confirm this fixes the issue with the v0.1.2 tag. Thanks!!