Allow configuring credentials in wp-config.php

Question

Allow configuring credentials in wp-config.php

rayrutjes opened this issue 6 years ago · comments

Allow the same as: https://community.algolia.com/wordpress/migration.html#ease-environment-switching-with-constants

First reported here: https://discourse.algolia.com/t/wp-config-api-for-woocommerce-order-search-admin/4402

Henrik Urlund · Answer 1 · Fri Aug 10 2018 03:03:40 GMT+0800 (China Standard Time)

@rayrutjes ... I'll suggest the following constant names to avoid a clash with the other constants, in case they - for some reason should have different values:

define ( 'WC_OSA_ALGOLIA_APPLICATION_ID', '<value>' );
define ( 'WC_OSA_ALGOLIA_SEARCH_API_KEY', '<value>' );
define ( 'WC_OSA_ALGOLIA_ADMIN_API_KEY', '<value>' );
define ( 'WC_OSA_ORDERS_INDEX_NAME', '<value>' );
define ( 'WC_OSA_ORDERS_PER_BATCH', '<value>' );

How does that sound?

Raymond Rutjes · Answer 2 · Fri Aug 10 2018 20:40:34 GMT+0800 (China Standard Time)

The suggested naming is perfect IMHO!

If you are doing a PR, please use conventional commit format: https://conventionalcommits.org/

That way, I'm sure to not steal your contribution again :/

Henrik Urlund · Answer 3 · Sun Aug 12 2018 20:49:27 GMT+0800 (China Standard Time)

@rayrutjes check PR #78 I hope it follows the conventional commit formats ;)

Henrik Urlund · Answer 4 · Sat Jan 19 2019 23:08:09 GMT+0800 (China Standard Time)

Fixed here #78

Raymond Rutjes · Answer 5 · Sat May 11 2019 23:56:19 GMT+0800 (China Standard Time)

Thanks for all the hard work @urlund and your patience.

You can now use constants in v1.11.0.