Annotation cache

Question

Annotation cache

bghveding opened this issue 9 years ago · comments

Bjørnar G. Hveding commented 9 years ago

Hi,

I was wondering what your thoughts are regarding the hardcoded AnnotationReader in Bind.php. Would you guys be open to have a reader as a possible constructor argument for example?

In my case I would like to use the CachedReader instead for performance.

PS: Great library!

Akihito Koriyama · Answer 1 · Sat Mar 28 2015 01:54:57 GMT+0800 (China Standard Time)

Hello @bghveding

Instead, You can cache Bind in your user code. It saves whole binding process include annotation reading. I add demo code for this at #46

I remove all cache mechanism from Ray.Aop and Ray.Di component for v2 aim to have more cleaner design. I intentionally hard code for that constructor, but if you think I'm still missing something, Let me know. Discussion are welcome. :)

PS: Great library!

Thanks !

Bjørnar G. Hveding · Answer 2 · Sat Mar 28 2015 19:53:58 GMT+0800 (China Standard Time)

Thanks @koriym, that solves it :)

Akihito Koriyama · Answer 3 · Sat Mar 28 2015 21:43:08 GMT+0800 (China Standard Time)

@bghveding welcome ! thanks for the feedback. :)