rawls238 / PlanOut.js

A JavaScript port of Facebook's PlanOut Experimentation Framework

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Default Experiment causes unnecessary exposure logging

assiotis opened this issue · comments

I wanted to check if this was the intended behavior first before submitting a PR.
Namespace.js line 281, it will cause the default experiment to evaluate even if there is an experiment assigned to that segment. If the default experiment defines auto exposure logging, then the event will be logged twice, and given that the default experiment has a different salt (does not include the namespace prefix), those two values will potentially be different.

Looking at the python planout implementation, it turns out that I misunderstood the desired behavior of default experiments. They are meant to be simple key/value stores that experiment designers can use to define sensible defaults. The Python implementation goes as far as to explicitly define a DefaultExperiment class that bypasses exposure logging requests. Closing this issue.