raulfraile / distill

Smart compressed files extractor for PHP

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove Composer filesystem port

raulfraile opened this issue · comments

Currently, Distill uses a port of Composer's filesystem to get around rename issue: #9

I'm considering removing the port and use the Symfony Filesystem component in next version, but unfortunately the issue symfony/symfony#12533 is not fixed yet. Any comments @weaverryan @javiereguiluz @xabbuh?

@raulfraile What's your motivation for removing the port? That would basically re-open issue #9 as well, right?

@weaverryan yeah, that's why I don't want to remove it until symfony/symfony#12533 is fixed. As you pointed out in the PR, this was a temporary fix, and I would like to just rely on the Symfony Filesystem in the next major version.

It doesn't look like there's even a PR for symfony/symfony#12533. Obviously, the best-case scenario would be to make that PR with the fix, then happily remove the port from here :).

I still have the issue on my to do list. I can try to fix it this weekend.