Make xarray a default dependency

[JSKenyon]

Description

I believe that the time may have come to make xarray a core dependency rather than an extra. At present, it is optional as dask-ms implements its own stripped down Dataset. Unfortunately, this is introducing more and more maintenance as these stripped down Dataset objects do not implement a host of xarray.Dataset functionality. This means that writing tests can become frustrating as you have to write the tests anticipating two different Dataset implementations (or skip the tests entirely in the absence of xarray, somewhat defeating the point of writing tests). I am personally of the opinion that the xarray.Dataset representation should be fundamental to dask-ms, even if it is less lightweight.

The purpose of this issue is discussion - does anyone object?

[Benjamin Hugo]

No, I can't think of any good reason not to simplify this to just use xarray -- it is a stable package.

…

On Thu, Apr 21, 2022 at 9:23 AM JSKenyon ***@***.***> wrote: Description I believe that the time may have come to make xarray a core dependency rather than an extra. At present, it is optional as dask-ms implements its own stripped down Dataset. Unfortunately, this is introducing more and more maintenance as these stripped down Dataset objects do not implement a host of xarray.Dataset functionality. This means that writing tests can become frustrating as you have to write the tests anticipating two different Dataset implementations (or skip the tests entirely in the absence of xarray, somewhat defeating the point of writing tests). I am personally of the opinion that the xarray.Dataset representation should be fundamental to dask-ms, even if it is less lightweight. The purpose of this issue is discussion - does anyone object? — Reply to this email directly, view it on GitHub <#206>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4RE6SVRBAXAWFPOEOBVCDVGD66VANCNFSM5T6JGJFA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- -- Benjamin Hugo PhD. student, Centre for Radio Astronomy Techniques and Technologies Department of Physics and Electronics Rhodes University Junior software developer Radio Astronomy Research Group South African Radio Astronomy Observatory Black River Business Park Observatory Cape Town

[JSKenyon]

From offline discussion with Simon I now know that xova relies on the daskms.Dataset. I will continue to think about this as we don't want to break anything.