rastapasta / mapscii

new Buffer(size) got deprecated, use Buffer.alloc(size) instead.

Places in the code:

Lines 44 to 46 in 5873af5

    
           @pixelBuffer = new Buffer size 
        
           @foregroundBuffer = new Buffer size 
        
           @backgroundBuffer = new Buffer size

Buffer.alloc() got introduced in NodeJS 5.10.0. I think it is reasonable to raise the required Node version to the latest LTS.

https://nodejs.org/api/buffer.html#buffer_class_method_buffer_alloc_size_fill_encoding

You could also just raise to 6, which is LTS and still being maintained. Some well-known npm lib authors have done this recently.

Thanks for the mention of Node 6 which is still maintained until April of 2019.
Do you think it’s ok to require >= 6.14.0 as I did in #43?
There is still --ignore-engine for those those that wish to try earlier versions.

Do you think it’s ok to require >= 6.14.0 as I did in #43?
There is still --ignore-engine for those those that wish to try earlier versions.

Aside from the fact that you have no obligation to support anything, requiring the latest 6 version seems reasonable to me, as older versions have known security vulnerabilities.

@derhuerst Thank you so much for your input. I believe that the current decision is better than my previous judgment thanks to your posts.

	@pixelBuffer = new Buffer size
	@foregroundBuffer = new Buffer size
	@backgroundBuffer = new Buffer size

new Buffer(size) got deprecated