Giters

rappasoft / laravel-authentication-log

Log user authentication details and send new device notifications.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing "down" function to migration

zaherg opened this issue · comments

commented

Hey there,

The migration file here https://github.com/rappasoft/laravel-authentication-log/blob/main/database/migrations/create_authentication_log_table.php.stub is missing a down function to drop the table.

its not a big thing, but nice to have

commented

I stopped using down methods a long time ago but you're free to add it for your own project.

commented

Sounds good, then the docs should be updated to reflect your opinion,

Even though Taylor said he don't use it, their own packages, like jetstream, telescope .. etc, is shipped with down function for the migration.