Comments-related elements should not be displayed if comments are disabled
juergmessmer opened this issue · comments
Comments count or labels should not be displayed if comments are disabled.
Solutions:
• make a duplicate of the template and remove the related code
• but better maybe put identifierContexts around those elements and display them only if enabled
Is this about the admin interface or the templates used to render? If it’s
the latter, my stance is as follows: the title “comments for this entry”
(or similar) should still be displayed, with an additional message saying
that comments are disabled. But either way, this only concerns the default
template so it’s not really a problem since it can all be overridden using
a custom template set. If you want the title of the comment section to be
shown only if there are actually comments to be added, you could add them
only to the subtemplates for the moderated and the enabled case. Still, I
think we should gracefully handle the case where comments have been added
to an entry before they were turned off. Also, in the future it might be
possible for an entry to have comments disabled when they are enabled for
all other entries.
On 12.09.2012, at 08:01, "Jürg Messmer" notifications@github.com wrote:
Comments count or labels should not be displayed if comments are disabled.
Solutions:
• make a duplicate of the template and remove the related code
• but better maybe put identifierContexts around those elements and display
them only if enabled
—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/11.