rapidsai / node

GPU-accelerated data science and visualization in node

Home Page:https://rapidsai.github.io/node/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

BUG: `nullCount` related regression in `getJSONObject`

thomcom opened this issue · comments

nullCount and countNonNulls are not lining up. The nullmask after performing getJSONObject appears, perhaps, to be uninitialized.

rapids@tcomer-NVIDIA:~/node/modules/demo/api-server$ node null_count_test.js public/small-graph.json 
0
100
rapids@tcomer-NVIDIA:~/node/modules/demo/api-server$ node null_count_test.js public/large-graph.json 
0
100
rapids@tcomer-NVIDIA:~/node/modules/demo/api-server$ node null_count_test.js public/graphology.json 
1918976
81023
rapids@tcomer-NVIDIA:~/node/modules/demo/api-server$ cat null_count_test.js 
#! node

const file = process.argv[2];

const {Series} = require('@rapidsai/cudf');
const small = Series.readText(file);
const s2 = small.split('"edges":');
const edges2 = s2.gather([1], false);
const E2 = edges2.split('[\n').gather([1], false).split('},\n')
keys = E2.getJSONObject('.key')
console.log(keys.nullCount)
console.log(keys.countNonNulls())

There are no nulls in graphology.json, and the format of the numbers does not appear to change. This isn't trivial to track down.

This nullMask affects the use of gather directly, and most likely other cases. It caused a regression in my #397 work. I'll work on producing a minimal reproducer.

Now that I have my regression fixed (with setNullMask(1, 0)) I'm moving on for now.