rapidsai / node

GPU-accelerated data science and visualization in node

Home Page:https://rapidsai.github.io/node/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Move const array of `dtypes` to `dtypes.ts`

matekdev opened this issue · comments

We currently have an array of types declared inside of data_frame.ts (i,e NumericTypes, IntegralTypes)
https://github.com/mzegar/node-rapids/blob/6ab1bffc28e37b95331c14333bf635f566a44494/modules/cudf/src/data_frame.ts#L80

We should consider moving these definitions to dtypes.ts

We should also see if there are any other cases where we could reference these types instead, for example... replacing these calls.
https://github.com/rapidsai/node-rapids/blob/f2a367e65babb6d9692bb77a9545d80081d64afe/modules/cudf/src/data_frame.ts#L871