rapideditor / country-coder

📍➡️ 🇩🇰 Convert longitude-latitude pairs to ISO 3166-1 codes quickly and locally

Home Page:https://ideditor.codes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Emoji flag for Metropolitan France is broken

bhousel opened this issue · comments

https://github.com/ideditor/country-coder/blob/f7118179ba55c54d23e739918314ae12a93a6cf7/src/country-coder.ts#L226-L232

This works for most flags, but Metropolitan France uses the code fx which doesn't have a flag. Maybe it should just hardcode fr here?

I'm not sure if there are any other countries like this. Metropolitan France is kind of weird.

Screenshot 2020-06-22 14 49 49

Screenshot 2020-06-22 14 49 39

Hmm I'm not sure if we should hardcode this or not. Emoji flags are defined by two codepoints that correspond directly to the two-letter ISO codes, so returning a different emoji changes the identity.

FX is one of several unofficial yet "exceptionally reserved" codes we support in country-coder. Interestingly, the other ones have defined emojis. Some have their own symbol, like 🇮🇨 for IC, while others use the same rendering as the higher-level region, like 🇨🇵 for CP. You'd think FX would work similarly, but apparently not. It's the only ISO code I can see in country-coder without a corresponding emoji flag.

With this in mind, I'm thinking country-coder's behavior is technically correct and it's up to the ISO or Unicode Consortium to figure it out. But I'm also not against hardcoding if this is causing problems.

Interesting! I found this: https://en.wikipedia.org/wiki/Regional_Indicator_Symbol

It looks like a handful of these have been officially deprecated within CLDR, and FX is in that list. (I don't think any of the other deprecations are things I would even try to use).

I agree that country-coder's behavior is technically correct, so I'll close this and adjust the flag in the Location Conflation viewer.

@bhousel Sounds good. Countries and text encoding are both so complicated separately, it's a wonder there aren't more issues when they collide.