rapid7 / recog

Pattern recognition for hosts, services, and content

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

HMI device no assigned to proper Os.Device

nstylepro opened this issue · comments

<fingerprint pattern="^Siemens, SIMATIC HMI, ([^,]+),.*FW:\s*V([^,]+).*$">

This is an HMI (there is one more in the repo) that is 'HMI controller' yet it is under Os.Device='Monitoring'
Is this intentional or bug? if it's intentional please describe why

This looks like a bug and the correct value should be HMI Controller to match other entries. Would you like to PR this?

I can include this change in my next rollup PR if you prefer (should be in the next few days).

I can PR, tried to push my local branch but I do not have appropriate permissions

Thanks! Take a look at https://github.com/rapid7/recog/blob/master/CONTRIBUTING.md for instructions. The CPE/normalization stuff is not needed for this small change.

The issue has been addressed in PR #286 and #291