raphw / xjcoptional

A XJC plugin to make getters of optional properties Optional.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Optional generated for element having default value

driesva opened this issue · comments

We encountered a case where an Optional was generated for a default value.

Given the following XMLSchema:

<xsd:element name="volgnummer" type="algemeen:Volgnummer" minOccurs="0" default="1"/>

resulted in following Java code which does not compile:

    public Optional<Integer> getVolgnummer() {
        if (null == volgnummer) {
            return new Integer(1);
        }
        return volgnummer;
    }

(note: we als have a generator for default values)

It turns out the current check for default values is not sufficient. I'll provide a PR for it.