Captain hook plugin

Question

Captain hook plugin

SamMousa opened this issue 3 years ago · comments

The README mentions a Captain hook plugin, but the composer.json lists CaptainHook as a dependency.

I think either the README should reflect the CaptainHook library is a hard dependency, or it should be listed as a suggested dependency instead.

Let me know if you agree and I'll implement a PR. Personally I think, if possible, it would be best to list CaptainHook as an optional dependency.

Ben Ramsey · Answer 1 · Sat Dec 04 2021 00:08:32 GMT+0800 (China Standard Time)

Originally, I had intended this only as a CaptainHook plugin, but that changed at some point. So, yes, I think it would be fine to make CaptainHook a suggested dependency. Thanks!

Sam · Answer 2 · Mon Dec 06 2021 19:10:42 GMT+0800 (China Standard Time)

Will you do it or should i make a PR?

Ben Ramsey · Answer 3 · Wed Dec 08 2021 08:46:58 GMT+0800 (China Standard Time)

Feel free to make a PR, if you like. Otherwise, I'll try to get to this soon. Thanks!

Ben Ramsey · Answer 4 · Wed Apr 20 2022 10:57:38 GMT+0800 (China Standard Time)

Thanks for the suggestion. I released this in version 1.3.0.