Giters

ramhiser / sparsediscrim

Sparse and Regularized Discriminant Analysis in R

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Predict functions should return factors

ramhiser opened this issue · comments

commented

I noticed that when dlda() is called and then a predict call is made that a vector of strings is returned. Returning a vector of factors is preferred. I'm not sure if classifiers other than dlda() are missing this feature, but need to double-check.

Write a unit test for each classifier to guarantee this.

commented

I have added this feature to each of the five diagonal classifiers.

commented

Still need to write unit test for this.