pathEq types are not consistent with the code in 0.29.0

Question

pathEq types are not consistent with the code in 0.29.0

dibell opened this issue a year ago · comments

0.29.0 added a breaking change to pathEq, swapping the parameter order: val, path, obj
The types-ramda 0.29.2 package is not in line with this: path, val, obj

types-ramda is correct in the develop branch. This needs to be pushed out to match the 0.29.0 release.

Harris Miller · Answer 1 · Tue Jun 06 2023 12:33:48 GMT+0800 (China Standard Time)

@dibell fix was released in types-ramda@0.29.3: https://github.com/ramda/types/releases/tag/v0.29.3

Daniel Gruszczyk · Answer 2 · Fri Jun 23 2023 16:43:55 GMT+0800 (China Standard Time)

This doesn't seem to be available on npm yet:
https://www.npmjs.com/package/@types/ramda?activeTab=versions
Latest is 0.29.2

Kevin Wallace · Answer 3 · Mon Jun 26 2023 23:06:10 GMT+0800 (China Standard Time)

@Harris-Miller do we need to do something to get this released by DefinitelyTyped?

Harris Miller · Answer 4 · Mon Jun 26 2023 23:33:59 GMT+0800 (China Standard Time)

@codan84 @kedashoe @types/ramda is 0.29.2 but it utilizes types-ramda 0.29.3. types-ramda is a patch release ahead due to a bad initial release. See here.

Playground example of pathEq being the correct argument order: https://tsplay.dev/WoxQ9w

Kevin Wallace · Answer 5 · Wed Jun 28 2023 13:06:13 GMT+0800 (China Standard Time)

@Harris-Miller not sure that playground example is pointing to the right place? In any event, installing @types/ramda looks like it grabs types-ramda 0.29.3, ty!