[bug] Don't re-request team reviews if the PR is already approved by the team
rallytime opened this issue · comments
Because of the the way review_request
events get triggered instead of opened
on some PRs, this action handling will occasionally re-trigger review requests on PRs, even if the team has already approved the PR.
You can see this happening here: saltstack/salt#46002
When I requested the review from Mike, it triggered a review_request
event and so the bot added team-core
and team-transport
back on the review list, even though those teams have already approve the PR. We need to account for this here.
If the team has already approved the PR, we need to make sure we filter that out in the API event back to GitHub.