Giters

rakaur / rhuidean

a small, lightweight IRC client library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

parsing KICK is a special case

rakaur opened this issue · comments

commented

This is more of a notification than an actual bug. I know that when you get on :KICK the user being kicked is in m.params[0] and that m.params[1] will have a : on the beginning. This is a special case with IRC where the protocol deviates from ":origin COMMAND target :freeform." The only real ways to fix it are

  1. Change the parser so that it always looks for that second token in all commands;
  2. Change the parser to be a real parser;
  3. Make a special case for KICK in the post-parse to rearrange it smarter.

One is silly. Two is slow and impractical. Three is doable but it would break any code that's out there right now. So for now it stays the same. If I ever release a new major version number I'll implement three. I don't see it happening though...

commented

I'll fix this in 2.0.