rajeshwarpatlolla / ionic-datepicker

'ionic-datepicker' bower component for ionic framework applications

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

clicking empty cells causes JS error

justinobney opened this issue · comments

I can't see any image or any error in the demo. Please use this link. http://rajeshwarpatlolla.github.io/DatePickerForIonicFramework/demo/#/tab/date-picker

Still getting issue: https://db.tt/uCLsmIHr

In the demo, the 31st is orphaned in a new row (only date left in month) I am simply clicking where the 3rd of the next month would be, if it were rendered. See the cursor position in the image.

I can see it now. Thanks for finding this issue. I am working on a new version of this component. I will try to fix this issue in that new version. May be you can expect that new new version in the next few hours.

This bug has been fixed. You can the new version i.e. v0.8.0.

commented

This issue still persist in example given at below URL:
http://rajeshwarpatlolla.github.io/DatePickerForIonicFramework/demo/#/tab/date-picker

See below image:
image

Steps:

  1. open date picker.
  2. click on empty cell at the div i shown in above image.
  3. date will set to nan and after setting this, date picker is not opening.

is there any way to solve this?

Yes, you are right. I can see it there. I will check the source code and will let you know, once it is fixed.

commented

Thanks a lot for quick reply. I think you can fix it by skipping this div for empty dates. Awaiting your reply.

Also, for pop-up mode, the date picker is quiet slow. Due to this multiple instances are opening when user clicks multiple times this also leads to application crash. I am going to try using model as suggested by you in another post.

Issue resolved. Code pushed to master branch. Please take a look at this commit.