radix-vue / shadcn-vue

Vue port of shadcn-ui

Home Page:https://www.shadcn-vue.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug]: Error in DropdownMenuRadioItem

GunniBusch opened this issue · comments

Reproduction

run npm run build

Describe the bug

I get this error from the component:

resources/js/Components/ui/dropdown-menu/DropdownMenuRadioItem.vue:27:4 - error TS2345: Argument of type '{ value: { value: string; disabled: boolean; textValue: string | undefined; asChild: boolean; as: AsTag | Component | undefined; }; [ComputedRefSymbol]: true; effect: ReactiveEffect<...>; [RefSymbol]: true; }' is not assignable to parameter of type 'Partial<{}> & Omit<{ readonly value: string; readonly as?: AsTag | Component | undefined; readonly asChild?: boolean | undefined; readonly disabled?: boolean | undefined; readonly textValue?: string | undefined; onSelect?: ((event: Event) => any) | undefined; } & ... 4 more ... & { ...; }, never> & Record<...>'.
  Type '{ value: { value: string; disabled: boolean; textValue: string | undefined; asChild: boolean; as: AsTag | Component | undefined; }; [ComputedRefSymbol]: true; effect: ReactiveEffect<...>; [RefSymbol]: true; }' is not assignable to type 'Omit<{ readonly value: string; readonly as?: AsTag | Component | undefined; readonly asChild?: boolean | undefined; readonly disabled?: boolean | undefined; readonly textValue?: string | undefined; onSelect?: ((event: Event) => any) | undefined; } & ... 4 more ... & { ...; }, never>'.
    Types of property 'value' are incompatible.
      Type '{ value: string; disabled: boolean; textValue: string | undefined; asChild: boolean; as: AsTag | Component | undefined; }' is not assignable to type 'string'.

27   <DropdownMenuRadioItem
      ~~~~~~~~~~~~~~~~~~~~~

System Info

System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Max
    Memory: 266.34 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Yarn: 1.22.22 - /opt/homebrew/bin/yarn
    npm: 10.5.0 - ~/Library/Application Support/Herd/config/nvm/versions/node/v21.7.3/bin/npm
    Watchman: 2024.05.06.00 - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 125.0.6422.112
    Edge: 125.0.2535.67
    Safari: 17.5
  npmPackages:
    @vueuse/core: ^10.9.0 => 10.9.0 
    radix-vue: ^1.8.1 => 1.8.1 
    vue: ^3.4.0 => 3.4.27 

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests

@GunniBusch can you try bump radix-vue version to 1.8.2 and see if the issue still persist? 😁