radicle-dev / radicle-upstream

Desktop client for Radicle.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improve patch list

rudolfs opened this issue · comments

The current patch list view has a couple of shortcomings, which can be easily addressed by:

  • adding counters to the filter tabs
  • replacing the "main <- patchId" component with a "Copy Link" button that only appears on hover
  • adding commit counters to each patch card
  • showing the patch author as well as the latest patch status done in 9dc890d
  • sort patches by newest first and don't group by author -> #2839

We'll need the comment counter later when we implement patch commenting and notifications.

Proposed:
Merged Patch List

What we have now:
Screenshot 2022-05-12 at 14 46 48

@rudolfs - can we also add "sorting by newest patch" to the requirements? I frequently came across closed patches being sorted out of order.

@rudolfs - can we also add "sorting by newest patch" to the requirements? I frequently came across closed patches being sorted out of order.

good idea, added.

Hm, now on second thought. I'll split it out in a separate issue, because to implement it we would need to add a timestamp to the patch metadata, otherwise we'd have to extract that information from the patch commits which isn't straightforward.

Skipping the commit counter for now because they're not easy to implement with the current way of calculating which commits belong to a patch and don't bring that much value.