Merge keystore into link?

Question

Merge keystore into link?

cloudhead opened this issue 4 years ago · comments

Now that there is no more registry to depend on radicle-keystore, should we merge it into the radicle-link repo?

xla · Answer 1 · Thu Sep 17 2020 03:08:02 GMT+0800 (China Standard Time)

Woohoo, we've come full circle! As long as we don't depend on published crates, one monorepo pinned at a single sha is the simplest to handle for downstream. Yet it didn't cause any trouble recently, so no strong preference.

Fintan Halpenny · Answer 2 · Thu Sep 17 2020 03:12:55 GMT+0800 (China Standard Time)

I don't see a need for us to take on that work, to be honest.

As long as we don't depend on published crates,

So maybe we can publish this crate since it's pretty stable at the moment? It can join radicle-surf in Crate Olympus

Kim Altintop · Answer 3 · Thu Sep 17 2020 19:22:49 GMT+0800 (China Standard Time)

I can't make myself enthused about a monorepo, unless we would also employ a build system which is designed for this kind of thing. Given the current situation (lock files, workspaces not truly isolating, incrementalism got a long way to go), it's just not going to work. And I'm not even talking about the lower incentives to create proper abstraction boundaries.

Kim Altintop · Answer 4 · Thu Sep 17 2020 19:27:50 GMT+0800 (China Standard Time)

Keep in mind also that this crate is potentially going to create executables, the link times of which you'd have to pay for.

Alexis Sellier · Answer 5 · Thu Sep 17 2020 23:23:06 GMT+0800 (China Standard Time)

Ok, I’m fine with keeping as-is, though I think it would have made it easier to do atomic changes across crates.

Is the build process fundamentally different when crates are in the same workspace, vs not? (Not that we’d be obliged to add it to the workspace)

Alexis Sellier · Answer 6 · Thu Sep 17 2020 23:32:02 GMT+0800 (China Standard Time)

Note that my proposal is about moving the crate to the radicle-link repo, not merging the code into librad.

Kim Altintop · Answer 7 · Fri Sep 18 2020 00:12:56 GMT+0800 (China Standard Time)

I'm not sure this is the right place to discuss how monorepos only work with specialised tooling. My point stands: cargo is painful enough already, and I'd rather split off more stuff into smaller repos. If you care about monorepos, please open an RFC on radicle-decisions. This will have to detail how we agree on questions of process, releases, non-linear development, builds, and tooling. We will need to reach for bazel or something comparable, so resources must be allocated to architect and implement the build pipeline.

Alexis Sellier · Answer 8 · Wed Sep 23 2020 17:08:41 GMT+0800 (China Standard Time)

Okay, this seems controversial, closing 👍