docker build failed
nyasukun opened this issue · comments
this Dockerfile is from python:2.7-onbuild.
However python:2.7-onbuild requires "requirements.txt."
It seems requirements.txt was deleted at this commit 76175fa
Since this, docker build always failed.
In my environment, it is successful to build with creating a link "requirments.txt" to "requirements/production.txt."
Thanks for reporting this issue. Clearly we need to be putting the docker build into our CI...
Is there any reason not to add requiments.txt as a link at root?
We have three options, as I see it:
- A symlink, which would cause problems for Windows users,
- A copy, which would work fine for Windows users, but create duplication,
- Move the file, which means we manage requirements files inconsistently (some in
requirements/, some not)
I guess 3. is probably the least-bad option.
I have another option:
- Modify Dockerfile to use the file under the
requirments/
see:
https://github.com/rackerlabs/mimic/compare/master...nyasukun:dockerfile_without_onbuild?expand=1
I think this option is better.
How do you think it?
Would adding a docker build step on travis be sufficient for adding this to CI?
@glyph sorry, that question was a bit unclear on my part. What I meant was, is the only concern that the image builds or should there be some tests run against the image?
@derwolfe - oh. well it would be nice to just get the build, for starters :). but ideally it would be just like the Mac app build; build the image, run the tests in the context of the thing that was just built
Oops, I guess the PR didn't have a "fixes" in its description. The word "solves" is not similarly magic :)
oh. sorry. I'm new in github and travis.
... It seems like this should have been closed, so I'll go ahead and close it :)