rOpenSpain / CatastRo

R package to query Sede Electrónica del Catastro (Spain)

Home Page:http://ropenspain.github.io/CatastRo/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

pkgcheck results - master

github-actions opened this issue · comments

Checks for CatastRo (v0.2.3)

git hash: b523bae5

  • ✔️ Package is already on CRAN.
  • ✔️ has a 'codemeta.json' file.
  • ✔️ has a 'contributing' file.
  • ✔️ uses 'roxygen2'.
  • ✔️ 'DESCRIPTION' has a URL field.
  • ✔️ 'DESCRIPTION' has a BugReports field.
  • ✔️ Package has at least one HTML vignette
  • ✔️ All functions have examples.
  • ✔️ Package has continuous integration checks.
  • ✖️ Package coverage is 52.9% (should be at least 75%).
  • ✔️ R CMD check found no errors.
  • ✔️ R CMD check found no warnings.

Important: All failing checks above must be addressed prior to proceeding

Package License: GPL-2


1. Package Dependencies

Details of Package Dependency Usage (click to open)

The table below tallies all function calls to all packages ('ncalls'), both internal (r-base + recommended, along with the package itself), and external (imported and suggested packages). 'NA' values indicate packages to which no identified calls to R functions could be found. Note that these results are generated by an automated code-tagging system which may not be entirely accurate.

type package ncalls
internal base 190
internal CatastRo 81
internal stats 5
internal graphics 3
internal utils 1
imports tibble 21
imports httr 11
imports sf 11
imports xml2 11
imports dplyr 5
imports mapSpain 2
imports rappdirs 2
imports stringi NA
imports terra NA
suggests ggplot2 NA
suggests knitr NA
suggests png NA
suggests rmarkdown NA
suggests slippymath NA
suggests testthat NA
suggests tidyterra NA
linking_to NA NA

Click below for tallies of functions used in each package. Locations of each call within this package may be generated locally by running 's <- pkgstats::pkgstats(<path/to/repo>)', and examining the 'external_calls' table.

base

unlist (20), paste0 (18), all (13), basename (12), list (12), grep (11), url (11), lapply (7), as.character (6), c (6), file.path (6), as.double (4), gsub (4), names (4), strsplit (4), switch (4), vapply (4), grepl (3), list.files (3), q (3), readLines (3), tempfile (3), try (3), unique (3), as.integer (2), as.POSIXct (2), attr (2), character (2), date (2), sprintf (2), tempdir (2), as.vector (1), file (1), file.exists (1), file.size (1), options (1), Sys.getenv (1), tryCatch (1), version (1), warning (1)

CatastRo

catr_hlp_dwnload (13), wfs_api_query (11), wfs_results (11), catr_read_atom (6), catr_atom_get_address_db_all (4), st_read_layers_encoding (4), catr_atom_get_buildings_db_all (3), catr_atom_get_parcels_db_all (3), wfs_bbox (3), catr_atom_get_address_db_to (2), catr_atom_get_buildings_db_to (2), catr_atom_get_parcels_db_to (2), catr_hlp_detect_cache_dir (2), catr_ovc_get_cod_munic (2), get_sf_from_bbox (2), catr_atom_get_address (1), catr_atom_get_buildings (1), catr_atom_get_parcels (1), catr_atom_search_munic (1), catr_clear_cache (1), catr_get_code_from_coords (1), catr_hlp_cachedir (1), catr_ovc_get_cod_provinces (1), catr_set_cache_dir (1), catr_wfs_check (1), catr_wfs_get_buildingsild_url (1)

tibble

tibble (11), as_tibble_row (6), deframe (4)

httr

content (3), GET (3), parse_url (3), modify_url (2)

sf

st_bbox (2), st_intersects (2), st_area (1), st_centroid (1), st_layers (1), st_point (1), st_read (1), st_sfc (1), st_transform (1)

xml2

as_list (7), read_xml (4)

dplyr

bind_cols (4), bind_rows (1)

stats

df (5)

graphics

title (2), lines (1)

mapSpain

esp_get_munic_siane (1), esp_getTiles (1)

rappdirs

user_config_dir (2)

utils

download.file (1)

NOTE: Some imported packages appear to have no associated function calls; please ensure with author that these 'Imports' are listed appropriately.


2. Statistical Properties

This package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing.

Details of statistical properties (click to open)

The package has:

  • code in R (100% in 25 files) and
  • 2 authors
  • 2 vignettes
  • 1 internal data file
  • 9 imported packages
  • 30 exported functions (median 18 lines of code)
  • 56 non-exported functions in R (median 26 lines of code)

Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
The following terminology is used:

  • loc = "Lines of Code"
  • fn = "function"
  • exp/not_exp = exported / not exported

All parameters are explained as tooltips in the locally-rendered HTML version of this report generated by the checks_to_markdown() function

The final measure (fn_call_network_size) is the total number of calls between functions (in R), or more abstract relationships between code objects in other languages. Values are flagged as "noteworthy" when they lie in the upper or lower 5th percentile.

measure value percentile noteworthy
files_R 25 86.3
files_vignettes 2 85.7
files_tests 19 96.0
loc_R 1365 76.0
loc_vignettes 293 62.8
loc_tests 718 81.6
num_vignettes 2 89.2
data_size_total 390 58.0
data_size_median 390 58.9
n_fns_r 86 72.4
n_fns_r_exported 30 78.3
n_fns_r_not_exported 56 70.6
n_fns_per_file_r 2 33.5
num_params_per_fn 4 54.6
loc_per_fn_r 24 67.4
loc_per_fn_r_exp 18 44.2
loc_per_fn_r_not_exp 26 73.5
rel_whitespace_R 30 85.4
rel_whitespace_vignettes 45 73.3
rel_whitespace_tests 30 86.2
doclines_per_fn_exp 78 83.8
doclines_per_fn_not_exp 0 0.0 TRUE
fn_call_network_size 78 75.0

2a. Network visualisation

An interactive visualisation of calls between objects in the package has been uploaded as a workflow artefact. To view it, click on results from the latest 'pkgcheck' action, scroll to the bottom, and click on the 'visual-network' artefact.


3. goodpractice and other checks

Details of goodpractice checks (click to open)

3a. Continuous Integration Badges

R-CMD-check

GitHub Workflow Results

id name conclusion sha run_number date
5713102963 Clean pkgdown manually success 2d3d27 17 2023-07-31
5765627088 Clear GHA caches manually success b523ba 1 2023-08-04
5761061384 CRAN Status Monitor success 2d3d27 87 2023-08-04
5765626362 lintr success b523ba 4 2023-08-04
5765682921 pages build and deployment success 6b1557 93 2023-08-04
5765627970 pkgcheck NA b523ba 1 2023-08-04
5765626363 R-CMD-check success b523ba 267 2023-08-04
5765626368 rostemplate-gh-pages success b523ba 59 2023-08-04
5765626366 test-coverage success b523ba 107 2023-08-04

3b. goodpractice results

R CMD check with rcmdcheck

R CMD check generated the following note:

  1. checking data for non-ASCII characters ... NOTE
    Note: found 3 marked UTF-8 strings

R CMD check generated the following check_fail:

  1. rcmdcheck_non_ascii_characters_in_data

Test coverage with covr

Package coverage: 52.85

The following files are not completely covered by tests:

file coverage
R/ovc_cpmrc.R 20%
R/ovc_munic.R 0%
R/ovc_provinces.R 0%
R/ovc_rccoor_distancia.R 19.64%
R/ovc_rccoor.R 19.64%
R/search_coords.R 0%
R/utils_read.R 59.38%
R/utils_wfs.R 26.04%
R/wfs_ad.R 18.52%
R/wfs_bu.R 40.48%
R/wfs_cp.R 14.29%
R/wms_all.R 24.07%

Cyclocomplexity with cyclocomp

The following functions have cyclocomplexity >= 15:

function cyclocomplexity
catr_hlp_dwnload 24
catr_hlp_detect_cache_dir 15
catr_set_cache_dir 15

Static code analyses with lintr

lintr found the following 37 potential issues:

message number of times
Lines should not be more than 80 characters. 37


Package Versions

package version
pkgstats 0.1.3.4
pkgcheck 0.1.2.1

Checks for CatastRo (v0.2.3)

git hash: 6b6f65eb

  • ✔️ Package is already on CRAN.
  • ✔️ has a 'codemeta.json' file.
  • ✔️ has a 'contributing' file.
  • ✔️ uses 'roxygen2'.
  • ✔️ 'DESCRIPTION' has a URL field.
  • ✔️ 'DESCRIPTION' has a BugReports field.
  • ✔️ Package has at least one HTML vignette
  • ✔️ All functions have examples.
  • ✔️ Package has continuous integration checks.
  • ✖️ Package coverage is 53% (should be at least 75%).
  • ✔️ R CMD check found no errors.
  • ✔️ R CMD check found no warnings.

Important: All failing checks above must be addressed prior to proceeding

Package License: GPL-2


1. Package Dependencies

Details of Package Dependency Usage (click to open)

The table below tallies all function calls to all packages ('ncalls'), both internal (r-base + recommended, along with the package itself), and external (imported and suggested packages). 'NA' values indicate packages to which no identified calls to R functions could be found. Note that these results are generated by an automated code-tagging system which may not be entirely accurate.

type package ncalls
internal base 183
internal CatastRo 80
internal utils 7
internal stats 5
internal graphics 3
imports tibble 21
imports httr 11
imports sf 9
imports xml2 9
imports dplyr 5
imports mapSpain 2
imports rappdirs 2
imports stringi NA
imports terra NA
suggests ggplot2 NA
suggests knitr NA
suggests png NA
suggests rmarkdown NA
suggests slippymath NA
suggests testthat NA
suggests tidyterra NA
linking_to NA NA

Click below for tallies of functions used in each package. Locations of each call within this package may be generated locally by running 's <- pkgstats::pkgstats(<path/to/repo>)', and examining the 'external_calls' table.

base

unlist (20), paste0 (18), all (13), basename (12), list (12), grep (11), url (10), lapply (7), c (6), file.path (6), gsub (5), as.double (4), names (4), strsplit (4), switch (4), vapply (4), as.character (3), list.files (3), q (3), readLines (3), tempfile (3), try (3), unique (3), as.integer (2), as.POSIXct (2), attr (2), character (2), date (2), sprintf (2), tempdir (2), as.vector (1), file.exists (1), file.size (1), options (1), Sys.getenv (1), tryCatch (1), version (1), warning (1)

CatastRo

catr_hlp_dwnload (13), wfs_api_query (11), wfs_results (11), catr_read_atom (6), catr_atom_get_address_db_all (4), st_read_layers_encoding (4), catr_atom_get_buildings_db_all (3), catr_atom_get_parcels_db_all (3), wfs_bbox (3), catr_atom_get_address_db_to (2), catr_atom_get_buildings_db_to (2), catr_atom_get_parcels_db_to (2), catr_hlp_detect_cache_dir (2), catr_ovc_get_cod_munic (2), get_sf_from_bbox (2), catr_atom_get_address (1), catr_atom_get_buildings (1), catr_atom_get_parcels (1), catr_atom_search_munic (1), catr_clear_cache (1), catr_get_code_from_coords (1), catr_hlp_cachedir (1), catr_set_cache_dir (1), catr_wfs_check (1), catr_wfs_get_buildingsild_url (1)

tibble

tibble (11), as_tibble_row (6), deframe (4)

httr

content (3), GET (3), parse_url (3), modify_url (2)

sf

st_bbox (2), st_intersects (2), st_area (1), st_centroid (1), st_point (1), st_sfc (1), st_transform (1)

xml2

as_list (6), read_xml (3)

utils

unzip (3), download.file (2), modifyList (2)

dplyr

bind_cols (4), bind_rows (1)

stats

df (5)

graphics

title (2), lines (1)

mapSpain

esp_get_munic_siane (1), esp_getTiles (1)

rappdirs

user_config_dir (2)

NOTE: Some imported packages appear to have no associated function calls; please ensure with author that these 'Imports' are listed appropriately.


2. Statistical Properties

This package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing.

Details of statistical properties (click to open)

The package has:

  • code in R (100% in 25 files) and
  • 2 authors
  • 2 vignettes
  • 1 internal data file
  • 9 imported packages
  • 30 exported functions (median 18 lines of code)
  • 56 non-exported functions in R (median 26 lines of code)

Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
The following terminology is used:

  • loc = "Lines of Code"
  • fn = "function"
  • exp/not_exp = exported / not exported

All parameters are explained as tooltips in the locally-rendered HTML version of this report generated by the checks_to_markdown() function

The final measure (fn_call_network_size) is the total number of calls between functions (in R), or more abstract relationships between code objects in other languages. Values are flagged as "noteworthy" when they lie in the upper or lower 5th percentile.

measure value percentile noteworthy
files_R 25 86.3
files_vignettes 2 85.7
files_tests 19 96.0
loc_R 1374 76.1
loc_vignettes 293 62.8
loc_tests 750 82.4
num_vignettes 2 89.2
data_size_total 390 58.0
data_size_median 390 58.9
n_fns_r 86 72.4
n_fns_r_exported 30 78.3
n_fns_r_not_exported 56 70.6
n_fns_per_file_r 2 33.5
num_params_per_fn 4 54.6
loc_per_fn_r 24 67.4
loc_per_fn_r_exp 18 44.2
loc_per_fn_r_not_exp 26 73.5
rel_whitespace_R 29 85.4
rel_whitespace_vignettes 45 73.3
rel_whitespace_tests 29 86.2
doclines_per_fn_exp 78 83.8
doclines_per_fn_not_exp 0 0.0 TRUE
fn_call_network_size 78 75.0

2a. Network visualisation

An interactive visualisation of calls between objects in the package has been uploaded as a workflow artefact. To view it, click on results from the latest 'pkgcheck' action, scroll to the bottom, and click on the 'visual-network' artefact.


3. goodpractice and other checks

Details of goodpractice checks (click to open)

3a. Continuous Integration Badges

R-CMD-check

GitHub Workflow Results

id name conclusion sha run_number date
5765627088 Clear GHA caches manually success b523ba 1 2023-08-04
5761061384 CRAN Status Monitor success 2d3d27 87 2023-08-04
5766754369 lintr success 6b6f65 6 2023-08-04
5766798083 pages build and deployment success 716e47 94 2023-08-04
5766816692 pkgcheck NA 6b6f65 2 2023-08-04
5766754370 R-CMD-check success 6b6f65 269 2023-08-04
5766754371 rostemplate-gh-pages success 6b6f65 60 2023-08-04
5766754365 test-coverage success 6b6f65 109 2023-08-04

3b. goodpractice results

R CMD check with rcmdcheck

R CMD check generated the following note:

  1. checking data for non-ASCII characters ... NOTE
    Note: found 3 marked UTF-8 strings

R CMD check generated the following check_fail:

  1. rcmdcheck_non_ascii_characters_in_data

Test coverage with covr

Package coverage: 53.04

The following files are not completely covered by tests:

file coverage
R/ovc_cpmrc.R 20%
R/ovc_munic.R 0%
R/ovc_provinces.R 0%
R/ovc_rccoor_distancia.R 19.64%
R/ovc_rccoor.R 19.64%
R/search_coords.R 0%
R/utils_read.R 67.65%
R/utils_wfs.R 26.04%
R/wfs_ad.R 18.52%
R/wfs_bu.R 40.48%
R/wfs_cp.R 14.29%
R/wms_all.R 24.07%

Cyclocomplexity with cyclocomp

The following functions have cyclocomplexity >= 15:

function cyclocomplexity
catr_hlp_dwnload 24
catr_set_cache_dir 15

Static code analyses with lintr

lintr found the following 28 potential issues:

message number of times
Lines should not be more than 80 characters. 28


Package Versions

package version
pkgstats 0.1.3.4
pkgcheck 0.1.2.1