Support JVS as Dataset

Question

Aria-K-Alethia opened this issue 5 years ago · comments

Hi,

I wonder if you want to add JVS as a dataset, it is a Japanese Multi-speaker speech dataset.

If you want, I think I can write the code.

Ryuichi Yamamoto · Answer 1 · Tue Dec 10 2019 20:01:55 GMT+0800 (China Standard Time)

That would be great to have. Do you mind making a PR?

Xin Detai · Answer 2 · Tue Dec 10 2019 20:14:09 GMT+0800 (China Standard Time)

That would be great to have. Do you mind making a PR?

OK, no problem.

Xin Detai · Answer 3 · Tue Dec 17 2019 10:04:52 GMT+0800 (China Standard Time)

Have you see the PR ? I committed the code, but seems can not pass the testcode, I don't know the reason...

Ryuichi Yamamoto · Answer 4 · Tue Dec 17 2019 12:01:50 GMT+0800 (China Standard Time)

Sorry! I’ve been busy for a while. I’ll take a look once I get some time.

Xin Detai · Answer 5 · Mon Dec 23 2019 15:10:19 GMT+0800 (China Standard Time)

Hi, I've fixed some of the inappropriate codes your mentioned, see it if you have time.

Xin Detai · Answer 6 · Mon Jan 06 2020 21:46:03 GMT+0800 (China Standard Time)

The code has been modified, however I don't know why the CI test failed again.

Ryuichi Yamamoto · Answer 7 · Wed Jan 08 2020 11:54:28 GMT+0800 (China Standard Time)

CI failure doesn't seem to be related to your changes. Let me see if it still persists after merging the PR.

Ryuichi Yamamoto · Answer 8 · Wed Jan 08 2020 11:55:26 GMT+0800 (China Standard Time)

note to self: better to update docs and changelogs as well. After that, I will close the issue.

Ryuichi Yamamoto · Answer 9 · Wed Jan 08 2020 12:41:58 GMT+0800 (China Standard Time)

CI failure seems related to nedbat/coveragepy#916