[Feature Request] Add touchpad swipes using ViGEmBus 1.17?
gaveitatry2 opened this issue · comments
I found out that ViGEmBus 1.17 will allow programs such as yours to implement touchpad swipes. Could you add this feature? For more information, please visit this GitHub thread - nefarius/ViGEmBus#79
Hi, I will look soon
This is just me venting, doesn't have anything to do with this issue (ticket) that I created. I had the 7 day trial for PlayStation Now, but I took my time playing The Last of Us so it ended up taking 9 days for me to finish it. And since I renewed my subscription by one month for $11, I wanted to find and play a few more good games. But I had a really difficult time finding any games on PlayStation Now that I actually wanted to play, and most of the games were already available on PC. After digging around, I finally found two games that I wanted to play. Until Dawn and The Darkness (I had already played the sequel). Until Dawn, sadly required touchpad swipes, which I think is idiotic. It wasn't necessary to use touchpad swipes for lighting up a lighter 3-5 times in the game or for flipping pages in a book. But there was no emulator program in existence that I know of that supports touchpad swipes, except reWASD. So I gave it a try, and I have to say that it is a trillion times worse than your program. It was a steaming pile of sh. In fact, it was so bad, that I found myself in the very beginning of my playthrough of Until Dawn hoping that I could finish the game in a hurry because I couldn't wait to uninstall reWASD and get it off my computer. Of course later I really liked Until Dawn a lot, so I wasn't that much in a hurry to quit playing the game. Their program was so bad, that I ended up using DS4Emulator 98% of the time, and just switching controllers to reWASD the few times that I needed to do swipes like when flipping pages and lighting up lighters. Their program was a real pain in the arse. Really, if and when you do add swipes, your program which is already a billion times better is going to be a trillion times a trillion times better. Just be sure to add at least left swipe and right swipe. Up and down may be important, but if you have to prioritize, start with those two, because those were the two that I had to use in Until Dawn. My PlayStation subscription will end on March 13, and I'm not going to renew it anytime soon unless I get some crowdfunding donations which will probably never happen. So I won't be able to use your awesome program for much longer. But I have to say it is a really sweet program, the best there is, and you should be proud of your masterpiece of an emulator. It also has a really sweet name. DS4Emulator. I like it. Thanks for all you do and for creating this wonderful software.
I have tried adding this, but so far without success.
Yeah, I'm sure it's not easy to figure out. Did you try asking the ViGEmBus developer for help or for some helpful documentation?
ViGEm Discord
https://discord.com/invite/EHmru73
ViGEm Forums
https://forums.vigem.org/
It seems I was able to add support, could you please check if it works correctly?
DS4_Test_Touchpad.zip
The touchpad is still attached to the numpad arrows, to make a swipe from left to right, you need to press Numpad 4 -> Numpad 6.
Numpad 5 - center
Numpad 8 - up
Numpad 2 - down
1.) By default, all Notepad documents created in Windows 10 supports Unicode characters. For operating systems older than Windows 10 (Windows XP, 7, Vista, 8.1), it is still easy to create a Notepad document that supports Unicode characters. You just open up a blank Notepad document. Type or paste whatever you need. Then go to 'Save As', and then use the 'Encoding' drop down menu to select 'UTF-8' formatting. Then you save the document and put this config file in your zip file. All of your config files should support Unicode characters.
2.) Your touchpad swipe way requires me to press two buttons very quickly, one after another. reWASD uses the same ViGEmBus 1.7, but they have one button for each swipe. So if I wanted to turn a page from right to left using reWASD, I would only need to press one button. But yours, I have to press Numpad 6 and then Numpad 4 real quick. But hey, at least it works. It's better than nothing. But honestly, I don't use Numpad. The Logitech Bluetooth keyboard that I have does not have Numpad. So it would be nice if you combine the two keys per swipe into one key and then let us customize what key code we want to use like "1, 2, 3, 4" or some other keys. Luckily, my laptop had a working Numpad. But on my other laptop, it had a factory defect where the keyboard doesn't work. That is why I bought the Logitech Bluetooth keyboard in the first place. I don't like using multiple keyboards. So I would prefer a way to not be forced to use Numpad, if possible.
But overall, it is definitely good progress. You finally figured out how to get the API working. You just need to improve it and make it so that each swipe only requires one button. I only tested left and right swipes because the 'Until Dawn' game does not use up and down swipes. Thank you for working on this!
Numpad is used as a temporary solution, I will add changing buttons for touchpad as well as buttons for swipes.
I've added these improvements, it would be great if you could check it out in PS Now. Swipes to "9" and "0" and touchpad movements with "u", "h", "j", "k", "n".
DS4_Touchpad_RC1.zip
1.) The TOUCHPAD_SWIPE_LEFT and TOUCHPAD_SWIPE_RIGHT is not very responsive. Most of the time, it takes me 12-24 tries before it finally responds and swipes left/right. On reWASD, it always works right away on the first button press.
2.) If I use TOUCHPAD_LEFT and TOUCHPAD_RIGHT together to swipe, it is a little more reliable. Sometimes it swipes right away. But a lot of time, it takes around six or so tries.
3.) There should also be a TOUCHPAD_SWIPE_UP and a TOUCHPAD_SWIPE_DOWN. Don't forget them.
4.) You still did not make the config.ini file support Unicode (UTF-8). Whenever you finish working on this, please make the default Notepad document config file that is inside the DS4Emulator program zip folder support UTF-8 encoding.
I think that I tested everything. I could not test TOUCHPAD_UP, TOUCHPAD_DOWN, or TOUCHPAD_CENTER because of the game that I am playing.
PlayStation Now currently has a discount for a one month membership. It's $1 USD for one month. Normally it is $9.99 USD. The offer expires on March 29. I am going to wait until tomorrow to purchase it because I am tired right now and don't feel like doing any gaming. So anyway, if you need me to run any tests to help improve your program, let me know. I am currently using 1.5.1 and haven't updated yet, but I will once I subscribe to PlayStation Now again. Did you make any improvements to the swipes responsiveness? I mean, even if you don't, it's better than nothing. I just hope that you can improve it so that it works on the first press like it does in reWASD. But I am just happy to have swipes. So as long as the game doesn't have a time limit for the touchpad swipe, I am good.
Unfortunately not yet, it will be necessary to conduct more research on this topic.
If you buy a subscription in the future, you can check this version, This may have been fixed.
DS4Emu.A1.zip
DS4Emu.A1
The touchpad presses are way more reliable than the touchpad swipes. Using H+K and K+H to swipe right and left, it always takes less than 6 tries. Oftentimes between 2-4 tries. The touchpad swipes are just as bad as in previous versions. A lot of the time it took 6-10 times. Very few times it took 2 or 14 tries. But annoyingly, sometimes it would take as much as 35-45 tries for it to work. Touchpad swipes are very unreliable. I would prefer to use swipes instead of touchpad presses, but because the touchpad presses are way more reliable I think that players should use the touchpad presses instead. I have no knowledge whatsoever on coding or the API for this program, but maybe you can try experimenting with the speed. I noticed that when I use touchpad presses like H+K and K+H, it works better if I press them very quickly together without a long pause in between. So maybe for the touchpad swipes, you should speed things up a little. Try increasing the speed of the touchpad swipes by 5-10x and see if that helps?
Added new touchpad fixes in latest release
Hi. I probably won't be able to test the touchpad fixes anytime soon. I haven't subscribed to PlayStation Now in around 7 months and haven't used DSEmulator duing all of that time. I do plan to subscribe to PS Now again in a few days so I can play The Last of Us Part II, but I'll probably be spending all of my time playing that one game and doing other things in real life. I think that I will eventually try to test the touchpad controls in a previously played game, if it is still on PS Now, but it won't be right away. So I might not report back to you for 1-4.5 weeks. Thanks for continuing to work on this program though. Did you ever address the one suggestion/request I made a long time ago?
By default, all Notepad documents created in Windows 10 supports Unicode characters. For operating systems older than Windows 10 - Windows 8.1, 7, Vista, XP, you can create a Notepad document that supports Unicode characters by opening up a blank Notepad document, typing or pasting whatever you need, then going to 'Save As', and then using the 'Encoding' drop down menu to select 'UTF-8' formatting. Then you save the document and put this config file in your zip file. All of your config files should support Unicode characters by default so users won't have to create their own UTF-8 friendly config files themselves. I guarantee you that UTF-8 friendly config files are supported by every operating system and it will let us use special symbols and characters in the config file without having issues with saving. You really should use this type of formatting.
EDIT: I found out that I have until January 2022 to play The Last of Us Part II so I might wait a month or two before I subscribe and start playing.
Hey, I haven't tested out the newest version yet. I haven't used this program in like half a year. But I'll probably get a PSNow subscription around Black Friday on sale and then use your program to play The Last of Us Part II. I can't wait to test out the new features and improvements.
I have two ideas (not feature requests) if you are interested.
Idea #1
On the ViGEm GitHub (https://github.com/ViGEm/ViGEmBus), it has this listed:
Known users of ViGEm
A brief listing of projects/companies/vendors known to build upon the powers of ViGEm.
This list is non-exhaustive, if you'd like to see your project included, contact us!
3dRudder
Parsec
GloSC
UCR
InputMapper
Oculus VR, LLC.
Rainway, Inc
WiimoteHook
XJoy
HP
DS4Windows
XOutput
RdpGamepad
Touchmote
Mi-ViGEm
BetterJoy
Regame - Cloud Gaming Engine
And anytime I am on Reddit or look at YouTube, people are always suggesting reWASD. It annoys me to no end when people suggest using that program because even though it lets you change the key configs by using the interface instead of editing a config file, it's a crap program. I like your program way better. It's been a long time since I tested reWASD but it costs money, costs a lot of money in fact, and just plain sucks. People have no idea that your program exists and how great it is. I almost wish that no one will ever find out about your program. It can be a well kept secret. But these clowns have no idea. I'm surprised you haven't contacted ViGEm and asked them to list your program too. It's up to you if you want to do that or not. But maybe it didn't occur to you that you can do that or not, so I wanted to bring it to your attention.
Idea #2
You can add a discussions tab to your GitHub. So people can use this to ask you general questions instead of submitting issues. Not many GitHubs have this. Of all the GitHubs I ever visited, I think that I only saw one or two use this feature. But it's really nice to have and only takes 10 seconds to set up.
https://docs.github.com/en/discussions
So in one month I will test out 1.7.4 or whatever the latest version is and report back to you. I probably won't test or use the swipes. But I'm interested in the flashlight recharge and some other things.
Hi, I wrote in Vigem, asked to add, thanks! I have not seen this list before.
Seems discussions to be available by default https://github.com/r57zone/DualShock4-emulator/discussions
It looks like the touchpad works with the gamepad, probably this issue is no longer needed.