Giters

r2dbc / r2dbc-spi

Service Provider Interface for R2DBC Implementations

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

R2dbcType.CLOB/NCLOB have a default mapping of ByteBuffer.class

Michael-A-McMahon opened this issue · comments

commented

The values of CLOB and NCLOB are declared with ByteBuffer.class as a default Java type mapping:

r2dbc-spi/r2dbc-spi/src/main/java/io/r2dbc/spi/R2dbcType.java

Line 60 in 8de2fd0

CLOB(ByteBuffer.class),

r2dbc-spi/r2dbc-spi/src/main/java/io/r2dbc/spi/R2dbcType.java

Line 65 in 8de2fd0

NCLOB(ByteBuffer.class),

This conflicts with section 13.1 of the specification where String and Clob are listed as the default mappings:
https://r2dbc.io/spec/0.9.0.M1/spec/html/#datatypes.mapping

I think R2dbcType.CLOB and R2dbcType.NCLOB should be declared with String.class as their default mapping. I can create a pull request with that change if desired.

commented

That's indeed a bug on our side. BLOB is affected as well. Happy to merge a pull request.

commented

Let me know whether you plan on submitting a pull request or whether I should take care of this.

commented

I'd be happy to take this one. Should be a trivial change, so I can get a pull request ready today.