r00tman / NeRF-OSR

NeRF for Outdoor Scene Relighting [ECCV 2022]

Home Page:https://4dqv.mpi-inf.mpg.de/NeRF-OSR/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Weird Parameters?

MikePelton opened this issue · comments

Hi Viktor et al - very excited about this code, but in all the test*.sh files there's a parameter --test_env e.g.:
python ddp_test_nerf.py --config configs/europa/final.txt --render_splits static_path1_blend --test_env data/europa/final/static_path1_blend/envmaps
...but "--test-env" doesn't seem to be a supported parameter - I can't see it added anywhere in the code, and ddp_test_nerf.py never gets past the fact it doesn't recognise one or more parameters. Am I missing something obvious?

Hi, thank you! Sorry for the delay.

Yes, good catch. I think I initally uploaded the version where it was not yet there. The parameter should have controlled which lighting should be used for rendering. Specifically, the missing code starting from here should replace env with the lighting from the provided folder.

I just uploaded the correct version, which implements --test_env.
If there is any problem, please write here.

Brilliant - many thanks!