Should `use_logo()` call or suggest `pkgdown::build_favicons()`?
olivroy opened this issue · comments
In the wild, I noted that many packages have a logo in their package, but it is not recognized by usethis/pkgdown because the file is not named man/figures/logo.png
Examples of PRs I opened in various repos to address this.
- FRBCesab/rcompendium#59
- FRBCesab/rcompendium#58
- hsvab/odbr#43
- choonghyunryu/alookr#7
- cjvanlissa/worcs#140
- bertcarnell/tornado#10
- sfirke/janitor#553
- sportsdataverse/sportyR#33 (I didn't move logo there)
- lucarraro/OCNet#9
- lucarraro/rivnet#8
- pharmaR/riskmetric#326
The idea is that one can never build_site() locally and still have a running website, as use_pkgdown_github_actions() does that. However, as of pkgdown 2.1, favicons will no longer be built on CI.
Update from #844 + r-lib/pkgdown#2563
r-lib/pkgdown#2611 is a better solution!