Feature request/discussion: Updates to GitLab CI
billdenney opened this issue · comments
I'd like to take on adding more extensive support for GitLab CI. I would be willing to add the features/tests.
Before taking on the effort to update the GitLab code within usethis, I'd like to understand the appetite for accepting the PRs. Reading #293, #567, and others, I understand that the usethis maintainers do not use GitLab.
So, the question is: If I made some PRs to update GitLab CI to be closer to on-par with GitHub CI, would there be interest in reviewing/including them?
Thanks for checking in and for finding #293 and #567, which I think do still represent the situation.
My advice would be to create a package that implements the GitLab-using functions you are most interested in. I know that might mean inlining some internal helpers from usethis. When/if you do this, I'd be happy to take a look and see if I see a clear path towards bringing the functionality into usethis. But I doubt that will be the case. As it stands, the GitHub functionality is poorly covered by our automated tests and, basically, it's our own intense usage that serves as the tests. So I suspect we won't want to bring in a lot of tricky-to-test code for a platform we don't use.