Switch to `@exportS3Method()`
hadley opened this issue · comments
If a package includes register_s3() and we can use R 3.6.
usethis:::tidy_minimum_r_version()
#> [1] '3.6'The case where we can't assume/require R >= 3.6 would be pretty exceptional at this point, yeah? I realize this might not just be about packages following the tidyverse policy, but I assume there aren't lots of packages that are intentionally trying to support R 3.5 or earlier.
Oh yeah, I just forgot we can rely on 3.6 now.
We don't really have to add this to upkeep since roxygen2 will warn about undocumented S3 methods, but it might be a nice reminder?
@hadley Do you care to revisit / restate the call to action here?
I think we can turn this into individual issues on specific repos. So the job for one of us is to:
- Locate all packages that still use
s3_register() - For each package, analyse why we're using it and suggest what actions someone needs to take