Inconsistent start/startdate documentation
P-Storm opened this issue · comments
Hi,
I was looking into why there were no dates for example Balfolk Café Nijmegen with Androneda
.
See
Another entry that has it's date set:
This resulted in for example a json with the following fields:
- start_date
- end_date
And for the time set entry
- start
- end
This is inconsistent with the event scheme
https://github.com/qwandor/dancelist-data/blob/c2e98bd9bbebb0c07e5acd40d7793767097b7f09/events_schema.json
This file doesn't have the time entries (start/end).
So to be concrete:
- Can you update the
event_scheme.json
file to include start/end - Can you update the json to generate start_date/end_date when only start/end is given?
Point 2 should probably go into the repo of serving the website.
Does this version of the schema work for you? That's what the schema generation tool I'm using generates, but for some reason the VSCode extension I'm using doesn't seem to like it, which is why I didn't update it in this repository yet.
For your second point, the JSON, YAML and TOML all follow the same schema. The start
/end
fields already contain the date, so I don't want to duplicate this in the start_date
/end_date
. In fact the way the data structures are designed serde requires exactly one pair to be present in each event, so it's not possible to have both.
The event_scheme.json looks good. I was thinking in a structure of need start_date/end_date, and if you have the info you can put in the start/end (with time component). But that means indeed that you have to edit things with serde, but this is also fine
Will close this issue when you have figured it out how to let the proposed schema play nice :)