qvest-digital / terraform-kubernetes-aws-node-termination-handler

Terraform module to install the AWS Node Termination Handler

Home Page:https://registry.terraform.io/modules/iplabs/aws-node-termination-handler/kubernetes/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

When creating the ClusterRoleBinding the namespace was set to the account name

nigelellis opened this issue · comments

When setting up the ClusterRoleBinding the namespace is being set incorrectly. Module is using the account name vs. account namespace:

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  creationTimestamp: "2020-09-02T23:06:13Z"
  labels:
    app.kubernetes.io/managed-by: terraform
    app.kubernetes.io/name: aws-node-termination-handler
  name: aws-node-termination-handler
  resourceVersion: "184819743"
  selfLink: /apis/rbac.authorization.k8s.io/v1/clusterrolebindings/aws-node-termination-handler
  uid: 5bb0258b-741f-4f41-a506-16fb7e837647
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: aws-node-termination-handler
subjects:
- kind: ServiceAccount
  name: aws-node-termination-handler
  namespace: aws-node-termination-handler      <<< *****

PR to address is at #4

Thanks.

Closed by #4