Caddy's import path has changed

Question

Caddy's import path has changed

mholt opened this issue 5 years ago · comments

Caddy's import path (and Go module name) has changed from

github.com/mholt/caddy

to

github.com/caddyserver/caddy

Unfortunately, Go modules are not yet mature enough to handle a change like this (see https://golang.org/issue/26904 - "haven't implemented that part yet" but high on priority list for Go 1.14) which caught me off-guard. Using Go module's replace feature didn't act the way I expected, either. Caddy now fails to build with plugins until they update their import paths.

I've hacked a fix into the build server, so downloading Caddy with your plugin from our website should continue working without any changes on your part, for now. However, please take a moment and update your import paths, and do a new deploy on the website, because the workaround involves ignoring module checksums and performing a delicate recursive search-and-replace.

I'm terribly sorry about this. I did a number of tests and dry-runs to ensure the change would be smooth, but apparently some unknown combination of GOPATH, Go modules' lack of maturity, and other hidden variables in the system or environment must have covered up something I missed.

This bash script should make it easy (run it from your project's top-level directory):

find . -name '*.go' | while read -r f; do
	sed -i.bak 's/\/mholt\/caddy/\/caddyserver\/caddy/g' $f && rm $f.bak
done

We use this script in the build server as part of the temporary workaround.

Let me know if you have any questions! Sorry again for the inconvenience.

Sebastian Mancke · Answer 1 · Thu Jul 04 2019 17:49:44 GMT+0800 (China Standard Time)

@mholt No big thing, I'll do it soon (i guess at the weekend)

xombiemp · Answer 2 · Thu Jul 11 2019 01:07:14 GMT+0800 (China Standard Time)

@smancke Could you please fix this? I'm getting an error trying to install using this Archlinux package and I think this is why. https://aur.archlinux.org/packages/caddy/

xombiemp · Answer 3 · Wed Jul 17 2019 06:09:24 GMT+0800 (China Standard Time)

@smancke I tried to create a pull request, but I couldn't figure out the go modules. Would greatly appreciate a fix.

Benjamin Amling · Answer 4 · Wed Jul 17 2019 20:47:26 GMT+0800 (China Standard Time)

@smancke #136
I changed the import paths and tidied up the go.mod and go.sum files... just needs an approval. 😄

Benjamin Amling · Answer 5 · Wed Jul 17 2019 21:30:07 GMT+0800 (China Standard Time)

PR was merged, this issue can probably be closed now.

xombiemp · Answer 6 · Wed Jul 17 2019 23:57:35 GMT+0800 (China Standard Time)

@bamling Thanks for doing this!
@smancke So I think a new release has to be made now, is that correct?

Sebastian Mancke · Answer 7 · Thu Jul 18 2019 21:34:46 GMT+0800 (China Standard Time)

thx @bamling !
I have created the release for the caddy deployment.