New release to fix CLJS `Use of undeclared Var asami.entities/format`?

Question

New release to fix CLJS `Use of undeclared Var asami.entities/format`?

Snurppa opened this issue 2 years ago · comments

Hi Paula,

thanks for the lib.

I noticed that the latest release in Clojars does not include this commit which would fix CLJS warnings about format:

WARNING: Use of undeclared Var asami.entities/format at line 213 .cljs/.aot_cache/1.11.60/A8BA44C/asami/entities.cljc
WARNING: Use of undeclared Var asami.entities/format at line 221 .cljs/.aot_cache/1.11.60/A8BA44C/asami/entities.cljc

Can be reproduced in v2.3.2 with: clj -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "1.11.60"}} :paths ["src"]}' -M -m cljs.main --optimizations advanced -c asami.entities

Though it seems that commit brought a different warning into CLJS compilation. Running the same cljs.main command as above against main branch results in:

WARNING: Use of undeclared Var schema.core/split at line 18 /Users/joni.hamalainen/work/asami/src/asami/entities.cljc

Maybe you need to add #?(:cljs [clojure.string :as str]) and change the line 18 to use str/split ?

Thanks and happy new year!