Add custom flag support

Question

Add custom flag support

neworld opened this issue 5 years ago · comments

Andrius Semionovas commented 5 years ago

After the latest emulator upgrade, it won't launch inside docker anymore. After long hours I found, the flag -gpu swiftshader_indirect solve the problem. However, there is no API to provide such a flag.

Dustin Toff · Answer 1 · Wed Dec 11 2019 03:01:35 GMT+0800 (China Standard Time)

Hey @neworld, I like this feature; it makes a lot of sense and would definitely help unblock people that have issues like yourself or need to set their own flags just because they want to set feature flags. It seems like a simple enough change and will try to get to it as soon as I can.

I don't know if I'll be able to get to it this month with the holidays coming up so I would gladly welcome a PR for it but I'll do my best to support you as soon as I can

Andrius Semionovas · Answer 2 · Wed Dec 11 2019 04:55:10 GMT+0800 (China Standard Time)

Thanks for the approval. I suppose I could find time for it.

Dustin Toff · Answer 3 · Wed Dec 11 2019 07:43:11 GMT+0800 (China Standard Time)

I've gotten the bulk of the change done here (5beb2f7) but can't promise I can debug and fix the commit soon.

Andrius Semionovas · Answer 4 · Fri Dec 20 2019 03:48:54 GMT+0800 (China Standard Time)

Amazing! Thanks

Dustin Toff · Answer 5 · Fri Dec 20 2019 03:54:38 GMT+0800 (China Standard Time)

This got automatically closed with the push. Just need to tag the commit to get the release once I can prove https://travis-ci.com/quittle/gradle-android-emulator/builds/141814805 succeeds

Dustin Toff · Answer 6 · Fri Dec 20 2019 04:41:20 GMT+0800 (China Standard Time)

Okay, try out 0.1.0 and see if it works as you expect!