Bug in live version -- only display first few packets in sequence view
huitema opened this issue · comments
Describe the bug
Attached file. There are a couple hundred packets sent each way, but the "sequence" display stops at packet 9.
To Reproduce
- How did you load the file? From local storage
- Which visualization had the error? Sequence, server, generated client
Expected behavior
Would liek to see the whole sequence of packets
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
If you are having problems loading a file, please attach it to this issue or email it to us at robin.marx@uhasselt.be
Note that qvis is currently only tested and maintained for the latest stable versions of Google Chrome. -- I was using Firefox.
copied-to-text.txt
Hello @huitema,
I suspect you added recent support for datagram frames and forgot to quote the length field, making it invalid JSON.
Your file has the first unquoted length field at line 170:
[147295, "transport", "packet_received", { "packet_type": "1RTT", "header": { "packet_size": 1440, "packet_number": 9, "dcid": "42ff447d9e71d777" }, "frames": [{
"frame_type": "datagram", length: 1411}]}],
qvis tries to be clever and falls back to a line-by-line parser when it's invalid JSON, but does stop once it encounters a line with an obvious error. As such, you get a nice qlog file of the entries before line 169, and nothing after that.
I replaced all the unquoted lengths with "length" in your example and that seems to load just fine:
quoted-lengths.txt
If this solves your problem, please close this issue.
If not, please let me know!
Thanks. This is being fixed in picoquic pr #1245