Duplicate error guesstimation in packetization diagram
rmarx opened this issue · comments
It seems like the packetization diagram changes some internal state after drawing for the first time, mainly related to how we do the auto-generated FILLER frames.
To reproduce: load example files, go to packetization tab, load the "10 parallel files". In the middle in the bottom part for packet nr 4, you'll see that the QUIC frame header is almost entirely red with a little yellow. Now click any other tab, and come back to the packetization. Suddenly, packet nr 4 has a much larger yellow area up front. This also happens with some other traces such as SPIN_BIT.
I think this might be happening due to a double loop where we calculate things the second time around based on the output of the first due to an error (since we store the results of the first time in the qlog data directly).
Leaving this open for now since it doesn't really introduce any errors atm (frame sizes are guesstimated anyway) and we have to revise this code anyway when adding proper support for frame.raw.length and frame.raw.payload_length soon.