questdb / questdb-connect

SQLAchemy and Apache Superset extensions for QuestDB

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SADeprecationWarning - Implement an import_dbapi()

PRICEKRAKEN opened this issue · comments

SADeprecationWarning: The dbapi() classmethod on dialect classes has been renamed to import_dbapi(). Implement an import_dbapi() classmethod directly on class <class 'questdb_connect.dialect.QuestDBDialect'> to remove this warning; the old .dbapi() classmethod may be maintained for backwards compatibility.

I see this project has requirement:

SQLAlchemy ('SQLAlchemy<=1.4.47')

After this merge it would be
SQLAlchemy ('SQLAlchemy >= 2.0')

I run the questdb-connect module already with SQLAlchemy 2.0.
Except the SADeprecationWarning i had no issues so far.

Can we work to bring this thing to SQLAlchemy 2.0 and onwards?
Or would it break to much?