ResultStreamer doesn't take inline:true into account for large data sets
jogoussard opened this issue · comments
ResultStreamer.java.txt
According to http://docs.qubole.com/en/latest/rest-api/command_api/view-command-results.html, a response can contain "inline": true while still having the results in S3. The simple inline test done in ResultStream#getResults needs to be expanded into:
boolean isInline = resultValue.isInline();
if (resultValue.getResult_location() != null && resultValue.getResult_location().size() > 0)
{
isInline = false;
}
if (isInline)
{
return new StringReader(resultValue.getResults());
}
return readFromS3(resultValue.getResult_location());
I have a fix for this, but can't push my branch for review (not authorized) - file attached.