quandyfactory / dicttoxml

Simple library to convert a Python dictionary or other native data type into a valid XML string.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Include README.markdown and LICENCE.txt in tarballs

stpierre opened this issue · comments

I've posed dicttoxml for inclusion in Fedora and EPEL (https://bugzilla.redhat.com/show_bug.cgi?id=1084199), and they'd like the licence included in the tarball so that there's more of a guarantee that the LICENSE file for a given release agrees with the actual license for that release. Would it be possible to include LICENSE.txt (and, ideally, README.markdown) in the release tarballs in the future?

Thanks!

The solution for this is to include a MANIFEST.in in the sources containing

include README.markdown LICENSE.txt

This way python setup.py sdist will automatically include those files

Thanks, I wasn't sure how the tarballs were created for this project since they're stored in Git itself, which is a pattern I hadn't seen before. Closing this in favor of #16.

Yeah that's just that the dist folder should be ignored from the sources and instead upstream should tag the releases in git :)

You as packager should rely on pypi though ;-)

Thank you for raising this issue. I agree completely with your reasoning and approach and will merge your pull request this evening.