data-cacheid aren't cleaned up before code snippets are taken

Question

data-cacheid aren't cleaned up before code snippets are taken

WilcoFiers opened this issue 9 years ago · comments

I've been finding a lot of data-cacheid attributes in the code snippets returned by Quail. I think this is caused by the color tests. This may be confusing to users.

Chris Baldwin · Answer 1 · Tue Jul 07 2015 11:21:00 GMT+0800 (China Standard Time)

Using elem.dataset or jQuery.data() should keep these out of the DOM.

Chris Baldwin · Answer 2 · Tue Jul 07 2015 12:17:02 GMT+0800 (China Standard Time)

Tried using dataset but it threw TypeError: 'undefined' is not an object (evaluating 'element.dataset.cacheId') during testing.

Pretty sure I'm missing something obvious here, but the jQuery .data() method seems to work and gets rid of these data-cacheid attributes in reports.

J. Renée Beach · Answer 3 · Tue Jul 28 2015 01:02:48 GMT+0800 (China Standard Time)

Fixed by PR #360 .