Make JIT usable on Windows

Question

Make JIT usable on Windows

qmonnet opened this issue 7 years ago · comments

Would be great to have rbpf compiling on Windows.

AppVeyor is free and easy to setup as CI as well to run the build. The jitting might be incompatible, but the rest should probably work.

See issue #19.

Jan-Erik Rediger commented 7 years ago

Yes!

Jan-Erik Rediger · Answer 1 · Mon Sep 04 2017 20:39:31 GMT+0800 (China Standard Time)

If you give me push access to the repo I should be able to set it all up

Quentin Monnet · Answer 2 · Mon Sep 04 2017 20:45:37 GMT+0800 (China Standard Time)

Just added you as a “collaborator” on the repo, I think this gives you the permission to push?

Jan-Erik Rediger · Answer 3 · Mon Sep 04 2017 20:54:49 GMT+0800 (China Standard Time)

So it seems it's not easy to compile on Windows: https://ci.appveyor.com/project/badboy/rbpf/build/job/9kmut2g40uto44qp

I could skip all jit things in Windows builds, but that would severly strip down the library

Quentin Monnet · Answer 4 · Mon Sep 04 2017 21:17:05 GMT+0800 (China Standard Time)

Yeah, having the JIT is great, but… I don't know if there is something equivalent on Windows to the posix_memalign() and mprotect() functions we're using, and don't really have time to investigate to be honest.

So I'd go for a “first step” without JIT on Windows, I think. Does it compile without the JIT?

Jan-Erik Rediger · Answer 5 · Mon Sep 04 2017 22:01:54 GMT+0800 (China Standard Time)

According to various internet resources VirtualAlloc can be used. I used it, but now the test is simply failing (probably a memory access error? I'm no Windows dev, so that's out of my area).
Skipping the JIT on Windows also affects most of the tests.

Quentin Monnet · Answer 6 · Tue Sep 05 2017 03:52:03 GMT+0800 (China Standard Time)

AppVeyor was added with #23. Renaming the issue, for the record: JIT compilation remains to be adapted for Windows.

Quentin Monnet · Answer 7 · Tue Sep 05 2017 04:00:37 GMT+0800 (China Standard Time)

@badboy Where can I check if the Windows build was triggered, and if it was successful? Maybe there's some badge somewhere we can add to the README for quick access to the builds, do you know about that?

Jan-Erik Rediger · Answer 8 · Tue Sep 05 2017 04:06:03 GMT+0800 (China Standard Time)

Hmm, it seems collaborator is not enough as I don't have the permissions to set any webhooks.
You can easily do so yourself though:

Go to https://ci.appveyor.com/
Login using your github account
Add a new project, select this repository
Check the settings, tick the "ignore branches without appveyor.yml" setting

In the settings you will also find a badge then. And from the overview page you can trigger a build.

Quentin Monnet · Answer 9 · Tue Sep 05 2017 16:02:46 GMT+0800 (China Standard Time)

Thanks!

I need to provide “Organizations and teams Read-only access” to AppVeyor in order to login with my GitHub account. I have to check that it's fine on my side, might take a couple of days before I add the project.

Quentin Monnet · Answer 10 · Sun Oct 08 2017 05:09:26 GMT+0800 (China Standard Time)

Hi @badboy, I'm sorry I let this issue slip out of my mind. The issue with the organizations being solved, I created an account on AppVeyor and added rbpf as a new project. The last commit added a badge to the README.md (can be blocked by add blockers, apparently).

Fixed by 4af0583

Quentin Monnet · Answer 11 · Sun Oct 08 2017 05:10:08 GMT+0800 (China Standard Time)

Reopening. I forgot the issue was about the JIT.

Quentin Monnet · Answer 12 · Thu Sep 07 2023 04:04:04 GMT+0800 (China Standard Time)

We have a new JIT that works on Windows (currently as an opt-in feature). #86