RFC: make asm_parser private
qmonnet opened this issue · comments
Quentin Monnet commented
I do not see any particular reason to offer the asm_parser
to the end user. As I see it, all the assembler API holds in the assembler
module. What about making asm_parser
private in src/lib.rs
? @rlane, any thought?
Note that as a consequence, we would have to move the tests from the separate file to a test
module at the end of file src/asm_parser.rs
. (I don't think the function/stucts from the module would remain accessible otherwise).
Rich Lane commented
Sounds good.