qiuqiao / SOFA

SOFA: Singing-Oriented Forced Aligner

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

can't train model because ph_seq is set to None

vocatart opened this issue · comments

commented

I don't know enough about python to be able to fix this problem with a pr, so I hope this is descriptive enough

commit 7cd5771 adds wav_length to _infer_once, but doesn't change arguments provided in validation_step

_, _, _, _, _, ctc, fig = self._infer_once(
input_feature,
ph_seq_g2p,
None,
None,
True,
True,
)

this sets ph_seq to None, causing _infer_once to fail with a NoneType error when using train.py. I reverted back to commit 2591e98 and this error was resolved.

commented

I'm sorry for submitting the commit without adequate testing. I will be more careful in the future.

commented

don't worry about it! I'm really happy with the results I'm getting with SOFA so far! keep up the good work :)